search

autonomousvision / giraffe

This repository contains the code for the CVPR 2021 paper "GIRAFFE: Representing Scenes as Compositional Generative Neural Feature Fields"
https://m-niemeyer.github.io/project-pages/giraffe/index.html
MIT License
1.23k stars 160 forks source link

Inconsistent docstring with code #29

Closed ifsheldon closed 3 years ago

ifsheldon commented 3 years ago

When reading the source code and trying to understand it, I found some inconsistency between docstrings and the code.

For two examples, the docstrings in im2scene.common.origin_to_world and im2scene.common.images_points__to_world say that the argument invert is

invert (bool): whether to invert matrices (default: true)

but the code is invert=False. Can you please check these? Thanks!