search

autonomousvision / unimatch

[TPAMI'23] Unifying Flow, Stereo and Depth Estimation
https://haofeixu.github.io/unimatch/
MIT License
1.05k stars 106 forks source link

Resetting hidden state during refinement #37

Closed qzed closed 7 months ago

qzed commented 1 year ago

It looks looks you're resetting the hidden-state during each RAFT-based refinement step. Is this done on purpose?

https://github.com/autonomousvision/unimatch/blob/0dfa3616d89790ac3bac3810dcdedf691b40dfdd/unimatch/unimatch.py#L317-L322

haofeixu commented 7 months ago

No, just based on intuitions :)

qzed commented 7 months ago

Thanks! Feel free to close this issue (although I think it could be nice to have a comparison whether this leads to some improvement).