search

autonomousvision / unimatch

[TPAMI'23] Unifying Flow, Stereo and Depth Estimation
https://haofeixu.github.io/unimatch/
MIT License
1.05k stars 106 forks source link

unimatch.py line 257 #47

Closed HaiLiExp closed 7 months ago

HaiLiExp commented 8 months ago

Hello

I wonder whether the min_depth and max_depth should be reversed because "min_depth" here is the inverse depth.

depth_up_pad = self.upsample_flow(depth_pad, feature0, is_depth=True).clamp(min=min_depth, max=max_depth)

BR Hai

haofeixu commented 7 months ago

Hi, it's inverse depth here, and it's converted to depth at https://github.com/autonomousvision/unimatch/blob/master/unimatch/unimatch.py#L360-L363