autonomousvision / unimatch

[TPAMI'23] Unifying Flow, Stereo and Depth Estimation
https://haofeixu.github.io/unimatch/
MIT License
980 stars 102 forks source link

Confusion about main_stereo.py #57

Open Liu-Zhen-Xin opened 2 months ago

Liu-Zhen-Xin commented 2 months ago

Very nice work! But maybe there is an oversight in main_stereo.py. After validation in training stage, model.training is still False since model.train() is not called until the new epoch is coming. When the length of train_loader is not equal with the val_freq, this may result in losing several supervisions of disparity except the last one.