search

autonomys-ambassadors / ambassador-os-peer-review

Automation for Ambassador OS Peer Review Process
Apache License 2.0
1 stars 1 forks source link

Some ambassadors were selected to review themselves #1

Closed jrwashburn closed 5 months ago

jrwashburn commented 5 months ago

Fradique reports some ambassadors were selected to review themselves - that should have been prevented.

jrwashburn commented 5 months ago

Tried to reproduce but failed. Requesting temporary access to sheet to run in debugger. There is code in place that should prevent this https://github.com/subspace-ambassadors/ambassador-os-peer-review/blob/4b442cda9fdd075b16134a9530c0242538565760/code.gs#L179 unless the handles are not matching across submission/reviewer data. Pending access to finish debugging.