jrwashburn
commented
2 days ago Sorry - we should have setup a fresh feature branch for this vs. re-using the one from issue 3. I changed the base to https://github.com/autonomys-ambassadors/ambassador-os-peer-review/tree/jrwashburn/issue8.
The code appears extensive due to numerous comments and logging, and some optimization is ongoing. Additionally, there are requirements and recommendations for the script to function correctly once it's complete. Here they are.
Column B (E-mail) in Overall score in Ambassadors' Scores can be deleted. Providing Discord handle in Submission Form also seems redundant, and isn't used in the script. Delete "Sheet 1" sheet in Ambassadors' Scores spreadsheet. The "too many triggers" error may occur periodically; please use the "Delete Triggers" menu item to resolve this. Please, rename sheet 'Overall score ' to 'Overall score' (remove space). Rename grades columns: Replace "Score or Evaluator's Email (if left unevaluated)" with "Score or Evaluator's Discord (if left unevaluated)" and concatenate them a number (-1, -2. -3). Expelled ambassadors are not (will not be) deleted from Registry list of ambassadors, but just are concatenated '(EXPELLED)' string to their e-mail address string. Do not allow multi selecting options in Evaluation Form. Set form limit to only one response. Editing seems ok.
Just note: Please, adjust formula: Cumulative Score columns has just well formula, adapted for changing the number of month sheets, but Average Score column has not. The formula should cover the entire range of column-months from the first to the last, adapting as new columns are added. "Penalty Points" column creating will be implemented in section 3.
Suggestion: The list of all ambassadors in the Overall Score could be pulled directly from the Registry, further reducing manual effort.