Closed marc-aurele-besner closed 1 week ago
Name | Link |
---|---|
Latest commit | b40a6a6af4464ac4e0d73fcd20e15b398d5e62b1 |
Latest deploy log | https://app.netlify.com/sites/dev-astral/deploys/672b982c1fa1470008dcd5dc |
Here are some key observations to aid the review process:
β±οΈ Estimated effort to review: 4 π΅π΅π΅π΅βͺ |
π§ͺ No relevant tests |
π No security concerns identified |
β‘ Recommended focus areas for review Environment Variable Handling The use of non-null assertion operator '!' with environment variables (e.g., `process.env.CHAIN_ID!`) assumes the presence of these variables without handling potential undefined cases. This could lead to runtime errors if the environment variables are not set. Type Assertion Direct type assertion in `process.env.RPC_URLS!?.split(",") as string[] | string` could lead to incorrect type assignments if the environment variable format is not as expected. Proper parsing and validation of environment variables should be implemented. Dynamic Environment Variables The introduction of dynamic environment variables (e.g., `${NETWORK_ID}`) in Docker Compose configurations requires careful management to ensure they are correctly set in all environments to avoid service misconfiguration. |
No code suggestions found for the PR.
User description
Simplify docker setup
PR Type
enhancement, configuration changes
Description
Changes walkthrough π
7 files
project.ts
Update environment variable names for network configuration
indexers/taurus/consensus/project.ts
project.ts
Update environment variable names for network configuration
indexers/taurus/leaderboard/project.ts
project.ts
Update environment variable names for network configuration
indexers/taurus/staking/project.ts
.env
Simplify and consolidate environment variables
.env
NETWORK_ID
environment variable.docker-compose.yml
Simplify and consolidate Docker Compose configurations
docker-compose.yml
init-db.sql
Simplify database initialization script
indexers/db/docker-entrypoint-initdb.d/init-db.sql
databases.yaml
Remove specific network database configurations
indexers/db/metadata/databases/databases.yaml - Removed specific network database configurations.
8 files
consensus_account_histories.yaml
Add table configuration for account histories
indexers/db/metadata/databases/default/tables/consensus_account_histories.yaml - Added new table configuration for `account_histories`.
consensus_account_profiles.yaml
Add table configuration for account profiles
indexers/db/metadata/databases/default/tables/consensus_account_profiles.yaml - Added new table configuration for `account_profiles`.
consensus_account_rewards.yaml
Add table configuration for account rewards
indexers/db/metadata/databases/default/tables/consensus_account_rewards.yaml - Added new table configuration for `account_rewards`.
consensus_accounts.yaml
Add table configuration for accounts
indexers/db/metadata/databases/default/tables/consensus_accounts.yaml - Added new table configuration for `accounts`.
consensus_blocks.yaml
Add table configuration for blocks
indexers/db/metadata/databases/default/tables/consensus_blocks.yaml - Added new table configuration for `blocks`.
consensus_event_modules.yaml
Add table configuration for event modules
indexers/db/metadata/databases/default/tables/consensus_event_modules.yaml - Added new table configuration for `event_modules`.
consensus_events.yaml
Add table configuration for events
indexers/db/metadata/databases/default/tables/consensus_events.yaml - Added new table configuration for `events`.
consensus_extrinsic_modules.yaml
Add table configuration for extrinsic modules
indexers/db/metadata/databases/default/tables/consensus_extrinsic_modules.yaml - Added new table configuration for `extrinsic_modules`.