auth and fix hasura proxy

DaMandal0rian commented 1 week ago

PR Type

enhancement, bug fix

Description

Improves https://github.com/autonomys/astral/pull/927
Added import auth to several endpoints to ensure authentication is applied.
Corrected the reverse proxy configuration to direct traffic to hasura:8080 instead of node:8080.
open other ports through caddy.
Improved logging setup across multiple endpoints to maintain consistency.

Changes walkthrough 📝

Relevant files

Enhancement

Caddyfile

Add authentication and fix Hasura proxy configuration

indexers/Caddyfile

Added import auth to multiple endpoints for authentication.

Changed reverse proxy target from node:8080 to hasura:8080.

Enhanced logging configuration for various endpoints.

+5/-1

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

netlify[bot] commented 1 week ago

Deploy Preview for dev-astral canceled.

Name	Link
Latest commit	34b12c0d07304d5c77745e0b90966d34686ee3e3
Latest deploy log	https://app.netlify.com/sites/dev-astral/deploys/672cf49c76e9e8000839d4de

github-actions[bot] commented 1 week ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Duplicate Code
The `read_buffer` setting is duplicated in the reverse proxy configuration for WebSocket traffic. This might be a copy-paste error and should be corrected to avoid potential misconfigurations.

github-actions[bot] commented 1 week ago

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Remove redundant buffer size configuration to clean up the configuration file ___ Check for potential redundancy in the `read_buffer` configuration under the `reverse_proxy` directive for HTTP traffic to Hasura. It appears twice, which might be a mistake or oversight. [indexers/Caddyfile [115-116]](https://github.com/autonomys/astral/pull/928/files#diff-8c93321a56d0377d04ecc3800259cf3f6d0f3dc73681ea63f4b91ac0b46f5ed2R115-R116) ```diff -read_buffer 64KB read_buffer 64KB ``` Suggestion importance[1-10]: 7 Why: This is a valid and useful suggestion that removes redundancy in the buffer size configuration, potentially preventing configuration errors and improving clarity.	7
Possible issue	Confirm the correctness of the proxy target change to ensure proper routing ___ Confirm that the change of the proxy target from `node:8080` to `hasura:8080` is intentional and correctly routes the traffic as expected in your infrastructure setup. [indexers/Caddyfile [112]](https://github.com/autonomys/astral/pull/928/files#diff-8c93321a56d0377d04ecc3800259cf3f6d0f3dc73681ea63f4b91ac0b46f5ed2R112-R112) ```diff -reverse_proxy hasura:8080 { +reverse_proxy hasura:8080 { # Confirm target change correctness ``` Suggestion importance[1-10]: 1 Why: The suggestion only adds a comment to confirm the change without providing a direct code improvement or addressing a specific issue in the PR.	1
Security	Verify and ensure correct configuration of the authentication import directive ___ Ensure that the `import auth` directive is correctly configured to handle authentication for the specified endpoints. Verify the configuration and integration of the authentication module to prevent unauthorized access. [indexers/Caddyfile [94]](https://github.com/autonomys/astral/pull/928/files#diff-8c93321a56d0377d04ecc3800259cf3f6d0f3dc73681ea63f4b91ac0b46f5ed2R94-R94) ```diff -import auth +import auth # Ensure correct configuration and integration ``` Suggestion importance[1-10]: 1 Why: The suggestion to verify the configuration is too generic and does not provide actionable code improvements. It only adds a comment without changing functionality.	1
Best practice	Ensure consistent application of authentication across all endpoints ___ Ensure that the `import auth` directive is added to all necessary endpoints consistently to maintain uniform security protocols across all services. [indexers/Caddyfile [94]](https://github.com/autonomys/astral/pull/928/files#diff-8c93321a56d0377d04ecc3800259cf3f6d0f3dc73681ea63f4b91ac0b46f5ed2R94-R94) ```diff -import auth +import auth # Verify inclusion at all required endpoints ``` Suggestion importance[1-10]: 1 Why: This suggestion repeats the verification of the 'import auth' directive without offering a specific improvement or change, merely suggesting to check for consistency.	1

autonomys / astral