autonomys / astral

Home of our Block Explorer
https://explorer.subspace.network
11 stars 9 forks source link

add node logging #942

Closed DaMandal0rian closed 14 hours ago

DaMandal0rian commented 1 day ago

PR Type

enhancement, configuration changes


Description


Changes walkthrough πŸ“

Relevant files
Enhancement
docker-compose.prod.yml
Add Loki logging configuration to node service                     

docker-compose.prod.yml
  • Added logging configuration for the node service.
  • Configured logging driver as loki.
  • Specified loki-url for logging endpoint.
  • +6/-2     
    Configuration changes
    docker-compose.yml
    Remove obsolete version specification                                       

    docker-compose.yml - Removed version specification from the file.
    +0/-2     

    πŸ’‘ PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    netlify[bot] commented 1 day ago

    Deploy Preview for dev-astral canceled.

    Name Link
    Latest commit 33dda0339fdb6d095bb441f236cef6220588da1f
    Latest deploy log https://app.netlify.com/sites/dev-astral/deploys/6734b6436311e90008e1998a
    github-actions[bot] commented 1 day ago

    PR Reviewer Guide πŸ”

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
    πŸ§ͺ No relevant tests
    πŸ”’ No security concerns identified
    ⚑ Recommended focus areas for review

    Configuration Validation
    Ensure that the 'loki-url' specified for the node service logging is correct and accessible.
    github-actions[bot] commented 1 day ago

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify and correct the loki-url to ensure reliable logging ___ **Ensure that the loki-url specified in the logging options for the node service is
    accessible and correct to avoid logging failures.** [docker-compose.prod.yml [31-33]](https://github.com/autonomys/astral/pull/942/files#diff-4563fbe997bbf18c3b38ad79c596c57c3ad88361f1dccb8c4f39b429382c06d3R31-R33) ```diff logging: driver: loki options: - loki-url: "https://logging.subspace.network/loki/api/v1/push" + loki-url: "https://corrected-url-if-needed/loki/api/v1/push" ```
    Suggestion importance[1-10]: 1 Why: The suggestion to verify the `loki-url` is non-actionable in code review since it does not provide a specific improvement or correction. It merely suggests a verification without identifying a concrete issue or providing a corrected URL.
    1