search

autonomys / space-acres

Space Acres is an opinionated GUI application for farming on Autonomys Network
59 stars 30 forks source link

Use `tray_icon` crate for better tray icon support #288

Closed dastansam closed 1 month ago

dastansam commented 2 months ago

closes #222

tested on MacOS

https://github.com/user-attachments/assets/f2f14388-e926-43d9-842d-38381c734e19

dastansam commented 2 months ago

I haven't yet tested this on non-MacOS Linux machine but I think I resolved all the comments code-wise @nazar-pc

nazar-pc commented 2 months ago

I did some refactoring, fixed some issues and added single left click handling. Tested on Windows and Ubuntu and confirmed that it works there at least.

@dastansam can you confirm it still works on macOS as expected?

nazar-pc commented 2 months ago

Still doesn't work on my Linux due to lack of legacy icons support in the library, but it is not worse than before, so not a blocker.

dastansam commented 1 month ago

I did some refactoring, fixed some issues and added single left click handling. Tested on Windows and Ubuntu and confirmed that it works there at least.

@dastansam can you confirm it still works on macOS as expected?

open button works fine, but close button quits the application. I thought it would just hide the window. Maybe then we can rename it Quit?

nazar-pc commented 1 month ago

I thought it would just hide the window. Maybe then we can rename it Quit?

It closes the app. It was working like this until you changed it, so I restored it back to what it was. Renaming is possible, but we'll have to update a bunch of translations in that case. I'll take care of it tomorrow alongside with one more improvement.