search

autonomys / subspace-desktop

A simple desktop farmer for the Subspace Network
Apache License 2.0
64 stars 22 forks source link

rotating logs and cargo toml cleanup #327

Closed ozgunozerk closed 2 years ago

ozgunozerk commented 2 years ago

Previous PR had conflicts with main regarding cargo lock, it was easier to create a new branch on top of the up to date main. I made the parameter 7 days for keeping the logs (it was about 24-30 mb daily for my case)

i1i1 commented 2 years ago

@ozgunozerk in those cases you can try deleting Cargo.lock and just run cargo check. This should generate a new one.

Though it has downsides as it will update all dependencies

ozgunozerk commented 2 years ago

LGTM. If the size of logs is our concern, may be a good idea would be to implement some lz4 storage layer which would compress logs.

This might allow us to increase log level for some crates (I think at least for subspace target at least debug should be helpful).

I agree, let us discuss this at the desktop meeting, and if we can arrive at a decision, we can take a look at it when we go back to desktop. I think it will be an overkill for now, since we may take a break from it soon