feat: remove unique record binary heap

autonomys / subspace

Subspace Network reference implementation

https://subspace.network

380 stars 243 forks source link

feat: remove unique record binary heap #2960

Closed tediou5 closed 2 months ago

tediou5 commented 3 months ago

After #2925, we've already flattened caches, so now we just need to use BTreeMap to manage them. Only the second commit makes sense.

close #1769

Code contributor checklist:

[x] I have read, understood and followed contributing guide

tediou5 commented 3 months ago

It's just an internal change that can be covered by existing tests. Now UniqueRecordBinaryHeap has been replaced byPieceCachesState internal BTreeMap inside , and UniqueRecordBinaryHeap's original functionality related tests have been covered by FarmerCache's basic test.

nazar-pc commented 2 months ago

Hey, do you plan to get back to this?

tediou5 commented 2 months ago

Hey, do you plan to get back to this?

Yeah, I just had a crazy busy two weeks. This week I'll have a little bit of down time, and next week I'll be happily back to the community.

tediou5 commented 2 months ago

All the problems have been solved. I think its ready.

nazar-pc commented 2 months ago

Squashed many commits so I don't have to see already fixed comments when going commit by commit, also fixed one typo

EmilFattakhov commented 3 weeks ago

Thank you so much for your contribution @tediou5! You will be rewarded for your contribution as a winner of the ongoing Autonomys Contribution Contest. Even though you've completed the compliance form before, we kindly ask you to submit it again to ensure that your residence and EVM wallet information is up to date, thanks!