search

autopilotpattern / mongodb

A robust and highly-scalable implementation of MongoDB in Docker using the Autopilot Pattern
Mozilla Public License 2.0
42 stars 20 forks source link

Update "containerpilot.json" to assume "consul" if "CONSUL" is unset #7

Closed tianon closed 7 years ago

tianon commented 7 years ago

This mimics the behavior of the Python code:

bin/manage.py:19:consul = pyconsul.Consul(host=os.environ.get('CONSUL', 'consul'))

This allows us to remove CONSUL=consul from the Compose files, thus allowing for local deploys to assume the correct value, and Triton deploys to use CNS via _env to set CONSUL=... to an appropriate value.

tianon commented 7 years ago

@misterbisson is there some kind of automated CI process that'll rebuild https://hub.docker.com/r/autopilotpattern/mongodb/, or do we need to beg someone with authority to do that manually? :wink:

misterbisson commented 7 years ago

is there some kind of automated CI process that'll rebuild https://hub.docker.com/r/autopilotpattern/mongodb/

No, not yet. Are you suggesting it would be to my own benefit to do that now?

How'bout I give you push privs to that Docker Hub repo?

tianon commented 7 years ago

I'd recommend finding a general solution to that problem given that there are a fair number of autopilotpattern repos now, but if you'd rather punt that problem to later and just let me push I won't mind. :smile:

misterbisson commented 7 years ago

I'd recommend finding a general solution to that problem

Yep. @tgross is working towards that (though focused on a different aspect of it first).

You should now have privs.