search

autopilotpattern / wordpress

A robust and highly-scalable implementation of WordPress in Docker using the Autopilot Pattern
GNU General Public License v2.0
158 stars 41 forks source link

Support ACME feature of autopilotpattern/nginx #34

Closed jasonpincin closed 7 years ago

jasonpincin commented 7 years ago

This PR updates the local Nginx configs so that the ACME features of latest autopilotpattern/nginx are supported.

jasonpincin commented 7 years ago

@misterbisson Here's the PR that re-combines the Nginx config templates in autopilotpattern/nginx: https://github.com/autopilotpattern/nginx/pull/32

misterbisson commented 7 years ago

This will also need changes in setup.sh to add the relevant config entries (commented out):

        echo '# Nginx LetsEncrypt (ACME) config' >> _env
        echo '# be sure ACME_DOMAIN and WORDPRESS_URL are the same, if using automated SSL via LetsEncrypt' >> _env
        echo '#ACME_ENV=production' >> _env
        echo '#ACME_DOMAIN=you.custom.domain' >> _env
misterbisson commented 7 years ago

Looking good. I pedantically called out some changes to be reverted before merging, but you knew about those.

The thing I'm really ashamed of is how long it took me to figure out how I'd made this work previously. I didn't use the conditional (which we'd want to avoid just because it's an extra conditional on every request), but it took me forever to spot the $server_port in proxy_set_header Host $host:$server_port; that I was using. That config file is in https://github.com/autopilotpattern/wordpress/issues/19 (which has a few things changed/removed for anonymity).

I PR'd those changes in https://github.com/jasonpincin/wordpress/pull/2 and https://github.com/jasonpincin/wordpress/pull/3, though if you're guessing I didn't build and test images with those changes....

misterbisson commented 7 years ago

From looking at https://hub.docker.com/r/autopilotpattern/wordpress/tags/ and https://hub.docker.com/r/autopilotpattern/wordpress-nginx/tags/, it looks like this should be tagged 4.5.3-r3 when merged.