search

autopkg / MLBZ521-recipes

AutoPkg Recipes
MIT License
14 stars 22 forks source link

Google Drive FS pkg_payload_path #34

Closed skoobasteeve closed 3 years ago

skoobasteeve commented 3 years ago

Google Drive made their installer Universal and now the payload contains both GoogleDrive_arm64.pkg and GoogleDrive_x86_64.pkg instead of a single GoogleDrive.pkg.

The good news is that this only breaks the PkgPayloadUnpacker processor which is only used to pull the version info, so it shouldn't matter which pkg it points to. Updated to point to the x86_64 version and all is working.

Let me know if you have any feedback, thanks for all your work.

stephen-bailey-carta commented 3 years ago

Seconded! Making this change would save me from having to override the pkg step. Thanks @skoobasteeve and @MLBZ521 for the efforts.

MLBZ521 commented 3 years ago

So sorry for the delay on this. I've been busy with several items at work and forgot about this PR. This is on my priority list to review asap. If I can, I'll get to it this weekend, otherwise, hopefully I can Monday.

MLBZ521 commented 3 years ago

@skoobasteeve Thanks again for the PR.

At some point, I need to determine how best to "rename" the recipe, removing the File Stream part of the name, as that has been dropped and it's back to just "Drive."

I think the most appropriate way would be to "deprecate" this one and create a new one, so I don't break anyones current runs.

MLBZ521 commented 3 years ago

Finally getting around to this...

16d508d Deprecated the Google Drive **_File Steam_** e46704b New Google Drive Recipes