search

autopkg / MLBZ521-recipes

AutoPkg Recipes
MIT License
14 stars 22 forks source link

Update Python path in processors to reflect changes in macOS 12.3+ #53

Closed homebysix closed 2 years ago

homebysix commented 2 years ago

As of macOS Monterey 12.3, the version of Python 2 that shipped with macOS located at /usr/bin/python has been removed. More context can be found in some posts from Mac admins at the beginning of 2022, aggregated here.

Since version 2.0.2, AutoPkg's installer has included its own Python 3 framework, symlinked from /usr/local/autopkg/python. This pull request adjusts the "shebang" interpreter paths of processors to replace /usr/bin/env python with the AutoPkg Python 3 path.

NOTE: Because AutoPkg processors are imported as modules by AutoPkg and not executed directly, processors' shebang has no effect in normal usage. However: (a) some people execute processors directly during testing, and these tests won't work unless the shebang points to a valid Python 3, and (b) having instances of /usr/bin/env python in the codebase could lead to confusion for people not deeply familiar with processor behavior.

Thank you for your consideration!

MLBZ521 commented 2 years ago

Thanks Elliot.

I've been slowly going through my Processors and updating the shebang along with some other standardization/cleanup stuff as I make changes to them, but since you did this, I figured now would be as good a time as any. So I have gone ahead and with through all of them and updated them and what not.