search

autopkg / andrewvalentine-recipes

6 stars 21 forks source link

Update Etcher.download.recipe #14

Closed fishd72 closed 5 years ago

fishd72 commented 5 years ago

It seems that they're pushing on with changes after the Resin.io rebrand and they're now altering the name of the download DMG and app bundle. I've tested these changes locally and they seem to now download the latest version (your current recipe seems to grab 1.4.4) but please test as I'm pretty new to AutoPKG recipes.

andrewvalentine commented 5 years ago

Thanks for spotting this. Your changes are totally fine! Now merged.

blackthroat commented 5 years ago

Since the update, I'm now getting this error:

CodeSignatureVerifier: Mounted disk image /Users/ladmin/Library/AutoPkg/Cache/local.munki.autopkg_Etcher/downloads/Etcher-1.4.4.dmg
Error processing path '/private/tmp/dmg.l7YC93/balenaEtcher.app' with glob. 
Failed.
fishd72 commented 5 years ago

Can you try clearing the cache and updating the repo? Latest version is 1.4.8 I think?

fishd72 commented 5 years ago

Ah, could be that the munki recipe also needs a change. I can look at that shortly but don’t have munki, so not really sure what it’s expecting. Is it just a dmg?

andrewvalentine commented 5 years ago

Can’t look at the moment, but will sort it out tomorrow.

andrewvalentine commented 5 years ago

Simply overlooked that the NAME input variable needing updating in both the .install and .munki recipes. Now fixed by https://github.com/autopkg/andrewvalentine-recipes/commit/2eac6f740e82917d328b9754dbb48e81da22cf78.