search

autopkg / andrewvalentine-recipes

6 stars 19 forks source link

Franz download recipe #18

Closed nilsbyte closed 5 years ago

nilsbyte commented 5 years ago

It looks like the download recipe does not what it should do. My Franz is outdated but the recipes are executed. Can you take a look @andrewvalentine ?

andrewvalentine commented 5 years ago

Fixed by 2eab9aa04365ed08390fe0c4fd196214b565a957

nilsbyte commented 5 years ago

Problem with this is, that your script is downloading the latest release, but not the pre-releases. The internal update mechanism of Franz is getting the pre-releases. Want to change that in your script?

andrewvalentine commented 5 years ago

That is by design, but I've now optimised all of the Franz recipes to leverage the INCLUDE_PRERELEASES function of GitHubReleasesInfoProvider. The .download specific commit is 87f445d7a701bb7da93025c3fbc7ed392a2d7b15.

andrewvalentine commented 5 years ago

Fixed with 87f445d7a701bb7da93025c3fbc7ed392a2d7b15.

opus-nbonenberger commented 5 years ago

I have tried it but it does not work. I just filled the string for the mentioned key with a 'true' in my override for the munki file. 

        <key>INCLUDE_PRERELEASES</key>
        <string>true</string>