search

autopkg / andrewvalentine-recipes

6 stars 19 forks source link

kodi.download.recipe #36

Closed blackthroat closed 3 years ago

blackthroat commented 3 years ago

I suspect kodi is now appending ?https=1 to their download links and the SEARCH_PATTERN needs to be adjusted:

URLTextSearcher
{'Input': {'re_pattern': '[^"]+\\.dmg[^"]*',
           'url': 'https://kodi.tv/download/851/'}}
URLTextSearcher: No value supplied for result_output_var_name, setting default value of: match
URLTextSearcher: Curl command: ['/usr/bin/curl', '--compressed', '--location', 'https://kodi.tv/download/851/']
URLTextSearcher: Found matching text (match): https://mirrors.kodi.tv/releases/osx/x86_64/kodi-18.8-Leia-x86_64.dmg?https=1
{'Output': {'match': 'https://mirrors.kodi.tv/releases/osx/x86_64/kodi-18.8-Leia-x86_64.dmg?https=1'}}
URLDownloader
{'Input': {'url': 'https://mirrors.kodi.tv/releases/osx/x86_64/kodi-18.8-Leia-x86_64.dmg?https=1'}}

This causes the munki import to fail:

MunkiImporter: /Users/ladmin/Library/AutoPkg/Cache/local.munki.autopkg_kodi/downloads/kodi-18.8-Leia-x86_64.dmg?https=1 is not a valid installer item!
blackthroat commented 3 years ago

This was resolved in PR https://github.com/autopkg/andrewvalentine-recipes/pull/38

Closing issue.