search

autopkg / apettinen-recipes

5 stars 16 forks source link

Brave browser GitHub releases broken; but does (now?) support appcast.xml #20

Closed jps3 closed 4 years ago

jps3 commented 5 years ago

https://updates.bravesoftware.com/sparkle/Brave-Browser/stable/appcast.xml

I have noted errors lately from AutoPkgr with messages like "Processor: GitHubReleasesInfoProvider: Error: No release assets were found that satisfy the criteria." While I did not got back in versions history of Brave, I do note that at least for v75.0.65.121 on a Mac test box, that it does have an SUFeedURL key in its Info.plist file pointing to the URL at the top of this message.

If I have a chance later today I will see if I can't submit a pull request. However, I am posting this here if anyone else wants to get on that more quickly.

apettinen commented 5 years ago

Hey! Thanks for reporting this. In addition to adding that autoupdate feed, they apparently also deprecated the original repo, and moved to https://github.com/brave/brave-browser - however, this is only for beta, developer, and nightly builds. In addition to that feed URL, there's a download link at their homepage, which we can use too.

So, I've now made changes so that the download recipe will use the direct download link from their homepage. The CodeSignature also changed, so that's fixed, as is the Munki and Install recipes too.

If desired, I can do a recipe that uses that appcast url.

apettinen commented 4 years ago

As #27 I related to this, I decided to finally use the appcast. Thanks for the original tip.

Fixed in https://github.com/autopkg/apettinen-recipes/commit/6a331bd9fcb6d624dda23cc6813c0ce40b884b78