search

autopkg / dataJAR-recipes

Elegant and powerful Apple services for business and education.
https://www.datajar.co.uk
Apache License 2.0
118 stars 85 forks source link

Feature request: specify folder for Adobe packages #196

Closed flammable closed 2 years ago

flammable commented 2 years ago

Thanks for the Adobe recipes! I haven't used them up until now, preferring to do the packaging manually...but honestly, it just takes too much time. Now that I'm being asked to build Adobe packages more frequently (argh), these should be a huge help. Thanks!

From checking out the README, I noticed that things are hardcoded to ~/Downloads. Would it be possible to allow for overriding this to another path, maybe passed as a parameter to the script? My laptop's internal SSD doesn't have enough disk space for all 34 packages I have to make, so I have an external SSD that I use solely for Adobe packaging.

I haven't looked at the script, but I might be able to just change ~/Downloads to my desired path, if this is something you're not looking to add. Thanks for considering this anyway!

macmule commented 2 years ago

I'm rejigging those recipes.. for 2021+.. will look to add

flammable commented 2 years ago

Thanks @macmule!

macmule commented 2 years ago

This is somewhat problematic.. as the Importer script creates a recipe_list to run through.. this will need to change to running each title in turn, with no recipe_list

macmule commented 2 years ago

Welp, looks like --report-plist overwrites the content of --report-plist with every run.. with a run being either a recipe list or a single recipe...

..and that report is processed by us to report on the run, internally.. so without a major rewrite for something we'll not use.. we can't add this without breaking functionality we need, sorry!

flammable commented 2 years ago

Oof. I'm not a Python programmer, but can I manually change DOWNLOADS_PATH (in Adobe2021Importer.py) and download_path (in Adobe2021Versioner.py) to another path?

I might try adding a symlink to my external drive in ~Downloads, then modifying both scripts to point to the symlink. That seems easier than specifying an entirely different path.

macmule commented 2 years ago

Might work, not sure.

There isn’t much error handling around the paths, as ~/Download should exist.

On Mon, 10 Jan 2022 at 15:52, Mike Solin @.***> wrote:

Oof. I'm not a Python programmer, but can I manually change DOWNLOADS_PATH (in Adobe2021Importer.py) and download_path (in Adobe2021Versioner.py) to another path?

I might try adding a symlink to my external drive in ~Downloads, then modifying both scripts to point to the symlink. That seems easier than specifying an entirely different path.

— Reply to this email directly, view it on GitHub https://github.com/autopkg/dataJAR-recipes/issues/196#issuecomment-1009016171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASZZTSZB76IXETTF3K4N4DUVL6DVANCNFSM5KKGB4NA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

--

Regards,

Ben