search

autopkg / dataJAR-recipes

Elegant and powerful Apple services for business and education.
https://www.datajar.co.uk
Apache License 2.0
116 stars 85 forks source link

Changes required to Lens.download #247

Closed Daz-wallace closed 2 years ago

Daz-wallace commented 2 years ago

Hey folks,

Looks like there are some changes needed to the Lens download recipe (and some possible upstream ones). Im gonna try and work through and ideally put in a PR but for now: 1) Download is now a .dmg rather than a .zip 2) URL is now something like (Lens-([0-9]+(\.[0-9]+)+)-latest\.dmg)

Thought I'd raise it early in case you get to it before me!

Daz-wallace commented 2 years ago

Taking a bit of a look at this, my RegEx-Fu isn't good enough to edit @paul-cossey's awesome work without redoing it simpler and breaking the dynamic Architecture choice :S

paul-cossey commented 2 years ago

Thanks for the heads up, @Daz-wallace

A .zip is still a valid download option so slightly less to change upstream :-)

Can you give this commit a try: https://github.com/autopkg/dataJAR-recipes/commit/bc198efa5ef63ee88d877f0931b69f775e85e4c6 please?

Cheers

Daz-wallace commented 2 years ago

Hey Paul, It seems to work great, thank you :)