autopkg / dataJAR-recipes

Elegant and powerful Apple services for business and education.
https://www.datajar.co.uk
Apache License 2.0
113 stars 80 forks source link

Update 4K Video Downloader.download.recipe #318

Closed SeanHansell closed 6 months ago

SeanHansell commented 6 months ago

URLTextSearcher was returning no match. Without user-agent, site was returning a blank href on the search: <a id="videodownloader_macos_" href="" onclick="dataLayer.push({event: 'app_download', product: 'videodownloader'}); ga('send', 'event', 'Download page', 'Download', 'videodownloader__'); setAppDownloadedStatus('videodownloader'); return true;" class="btn btn--primary links-list__button"><span class="links-list__button-text">Download</span><img class="links-list__button-img" src="https://static.4kdownload.com/main/img/redesign/arrow-download.ad18a64e30f5.svg" alt="Download"></a>

Adding a user-agent header caused the correct URL to appear, so included it in download recipe: <a id="videodownloader_macos_installer" href="https://dl.4kdownload.com/app/4kvideodownloader_4.29.0.dmg?source=website" onclick="dataLayer.push({event: 'app_download', product: 'videodownloader'}); ga('send', 'event', 'Download page', 'Download', 'videodownloader_4.29.0.5640_osx_x64'); setAppDownloadedStatus('videodownloader'); return true;" class="btn btn--primary links-list__button"><span class="links-list__button-text">Download</span><img class="links-list__button-img" src="https://static.4kdownload.com/main/img/redesign/arrow-download.ad18a64e30f5.svg" alt="Download"></a>

paul-cossey commented 6 months ago

Thanks, @SeanHansell