autopkg / dataJAR-recipes

Elegant and powerful Apple services for business and education.
https://www.datajar.co.uk
Apache License 2.0
113 stars 80 forks source link

nodejslts.download.recipe not finding the latest update #325

Closed arekdist closed 5 months ago

arekdist commented 5 months ago

I'm not sure what is going on with nodejslts.download.recipe but looking at the url of https://nodejs.org/en/blog with serch pattern eg.:

curl -s https://nodejs.org/en/blog | egrep -o "Node v([0-9]+(\.[0-9]+)+) \(LTS\)"
Node v18.20.1 (LTS)
Node v18.20.1 (LTS)
Node v18.20.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.0 (LTS)
Node v20.12.0 (LTS)
Node v20.12.0 (LTS)
Node v18.20.1 (LTS)
Node v18.20.1 (LTS)
Node v18.20.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.1 (LTS)
Node v20.12.0 (LTS)
Node v20.12.0 (LTS)
Node v20.12.0 (LTS)

it looks as maintainer doesn't care about the correct order of updates and this source is probably not reliable. The effect of this is that currently autopkg imports version 18.20.1 as the "newest".

juloski commented 5 months ago

Comment for issue observation :)

paul-cossey commented 5 months ago

Thanks for raising this,

Looking at https://nodejs.org/en/blog/release it seems 18.20.1 is the latest or at least it just so happens to have been the version most recently updated.

Screenshot 2024-04-05 at 09 59 39
paul-cossey commented 5 months ago

We could use this https://nodejs.org/dist/ and have major version as a variable?

arekdist commented 5 months ago

We could use this https://nodejs.org/dist/ and have major version as a variable?

Good idea!

paul-cossey commented 5 months ago

I might have time to get to it this afternoon, but if anyone has any immidiate capacity we accept PR's 😄

paul-cossey commented 5 months ago

Ok, updated the recipes. Could you give https://github.com/autopkg/dataJAR-recipes/commit/86473ce4328905818541cab0ffdcedb631e2aedb a try please?

I've tested with major versions 21, 20, 18 and seems ok here.

arekdist commented 5 months ago

Checked and works as expected. Thanks!

paul-cossey commented 5 months ago

Great, I'll close this off. Thanks for raising, @arekdist