search

autopkg / dataJAR-recipes

Elegant and powerful Apple services for business and education.
https://www.datajar.co.uk
Apache License 2.0
113 stars 80 forks source link

Update Nitro PDF Pro.download.recipe #332

Closed rickokid closed 4 months ago

rickokid commented 4 months ago

Looks like Nitro changed their download page slightly to have a capital V in version and a non-breaking space instead of a normal space. Tweaked pattern match lowercase or capital V and expect something between the colon and the version number but not care what (or how much).

paul-cossey commented 4 months ago

Hey, @rickokid

Thanks for this, I'm just testing your PR now, looks like the vendor has made some further changes (or maybe pulled a version?) I'm getting a 404 error when I run you updated download recipe. 

autopkg run -v /Users/paul.cossey/Downloads/Nitro\ PDF\ Pro.download.recipe 
**load_recipe time: 0.0004925419925712049
Processing /Users/paul.cossey/Downloads/Nitro PDF Pro.download.recipe...
WARNING: /Users/paul.cossey/Downloads/Nitro PDF Pro.download.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLTextSearcher
URLTextSearcher: Found matching text (version): 1.0
URLDownloader
URLDownloader: ERROR: (22) The requested URL returned error: 404

curl: (22) The requested URL returned error: 404

Failed.
paul-cossey commented 4 months ago

I've updated the regex on the download recipe, could you give this https://github.com/autopkg/dataJAR-recipes/commit/2a8c369513630e2d363f3633a0f13737330a166c commit a try please, @rickokid ?

Hopefully that resolve the issue for you?

rickokid commented 4 months ago

Works great, thanks!