search

autopkg / erikng-recipes

autopkg recipes
Apache License 2.0
2 stars 8 forks source link

Basic python3 compatibility, URLGetter superclass #3

Closed homebysix closed 4 years ago

homebysix commented 5 years ago

In order to make your processors more compatible with AutoPkg running in Python 3, I've applied a few adjustments suggested by python-modernize, pylint --py3k, and pylint in general.

Sorry for the large diff, but I think changing indentation to spaces will be helpful for potentially Blackening all AutoPkg Python code someday.

More adjustments may need to be made manually later (including handling HTTP headers), but this should catch the low-hanging fruit right now.

homebysix commented 4 years ago

Hi @erikng - Just checking in to see whether you're comfortable merging this in, or have any questions?

Some additional processor changes will be needed for the upcoming version 2.0 of AutoPkg, and it would be nice to build on the Python 3 compatibility adjustments made in this PR.

erikng commented 4 years ago

Sure. Want me to merge or you just want to update the PR? This got lost in the ether

homebysix commented 4 years ago

I updated the PR to include the AutoPkg 2.0-ready changes. Thanks!