Closed homebysix closed 4 years ago
Hi @pierrenicolasr - Just checking in to see whether you're comfortable merging this in, or have any questions?
Some additional processor changes will be needed for the upcoming version 2.0 of AutoPkg, and it would be nice to build on the Python 3 compatibility adjustments made in this PR.
Quick note: AutoPkg 2.0 is due to be released in early February 2020, and will run in Python 3 only.
Apologies, was super busy and autopkg/filewave repo fall under my radar. Many thanks for the contribution. We'll have to review the code to be full Python3 in a few when everybody will be using AutoPkg 2.0, but for now your PR for the compatibility mode works great. Thanks and apologies again !
In order to make your processors more compatible with AutoPkg running in Python 3, I've applied a few adjustments suggested by
python-modernize
,pylint --py3k
, andpylint
in general.More adjustments may need to be made manually later, but this should catch the low-hanging fruit right now.