search

autopkg / hansen-m-recipes

My recipes for Autopkg - https://github.com/autopkg
27 stars 50 forks source link

MSIInfoVersionProvider issue - should report an error #167

Closed jgstew closed 4 years ago

jgstew commented 4 years ago

When running autopkg run Zoom-Win.download it doesn't output any errors on a new setup of Autopkg, but when running autopkg run -vv Zoom-Win.download I get the error message:

URLDownloader: Using existing /Users/jamesstewart/Library/AutoPkg/Cache/com.github.hansen-m.download.zoom-win/downloads/Zoom.msi
{'Output': {'pathname': '/Users/jamesstewart/Library/AutoPkg/Cache/com.github.hansen-m.download.zoom-win/downloads/Zoom.msi'}}
com.github.hansen-m.SharedProcessors/MSIInfoVersionProvider
{'Input': {'msi_path': '/Users/jamesstewart/Library/AutoPkg/Cache/com.github.hansen-m.download.zoom-win/downloads/Zoom.msi'}}
MSIInfoVersionProvider: msiinfo executable not found.

Right now, MSIInfoVersionProvider: msiinfo executable not found. does not bubble up as a real error message at all, but it should even without specifying -vv

Also, the info about how to install msiinfo should also be included.

jgstew commented 4 years ago

The line is here: https://github.com/autopkg/hansen-m-recipes/blob/master/SharedProcessors/MSIInfoVersionProvider.py#L49

self.output("msiinfo executable not found.")

jgstew commented 4 years ago

This issue is resolved by this pull request: https://github.com/autopkg/hansen-m-recipes/pull/168

jgstew commented 4 years ago

would be interesting to add a msitools install recipe that uses brew. Is there a homebrew install recipe?

jgstew commented 4 years ago

this is resolved