search

autopkg / hjuutilainen-recipes

Recipes for AutoPkg
MIT License
50 stars 76 forks source link

TeamViewer recipe failing (ditto) #220

Closed opus-nbonenberger closed 1 year ago

opus-nbonenberger commented 2 years ago 
extraction of /Users/admin/Library/AutoPkg/Cache/local.munki.TeamViewer/unpack/TeamViewerApp.pkg/Payload with ditto failed: ditto: cpio read error: bad file format

Failed.

Autopkg 2.4.1

I don't know what to make of it.

LuisAddigy commented 2 years ago

Also encountering this error. Not sure if TeamViewerApp is no longer a pkg.

basdeg commented 2 years ago

TeamViewerApp.pkg is also no able to open via suspicious package Also expanding it via pkgutil does not work.

It might be the same issue as with MacOS updates maybe? https://exchangetuts.com/how-to-extract-contents-from-payload-file-in-a-apple-macos-update-package-1639690271789286

ellisdickinson46 commented 2 years ago

This issue is related to the PkgPayloadUnpacker processor included with Autopkg when attempting to decompress Payloads of modern macOS Packages.

There is a pull request (autopkg/autopkg#804) that addresses this issue by substituting commands ditto with aa when a failure is detected and aa is present. The aa command is able to decompress these newer archives without issue.

jannheider commented 1 year ago

Using Autopkg 2.7.2

Still get the error with "PkgPayloadUnpacker" or "PBXZPayloadUnpacker", both don't work.

PkgPayloadUnpacker: The following recipes failed: TeamViewer.munki Error in local.munki.TeamViewer: Processor: PkgPayloadUnpacker: Error: extraction of /Users/Shared/Jenkins/Library/AutoPkg/Cache/local.munki.TeamViewer/unpack/TeamViewerApp.pkg/Payload with ditto failed: ditto: cpio read error: bad file format

PBXZPayloadUnpacker: The following recipes failed: TeamViewer.munki Error in local.munki.TeamViewer: Processor: PBXZPayloadUnpacker: Error: extraction of /Users/Shared/Jenkins/Library/AutoPkg/Cache/local.munki.TeamViewer/unpack/TeamViewerApp.pkg/Payload with ditto failed: ditto: cpio read error: bad file format

Am i missing something or ist this still broken ? Should this work with the processor PBXZPayloadUnpacker ?

basdeg commented 1 year ago

All my issues are solved with autoPKG 2.7.2 and the latest update from this recipe which included PBXZPayloadUnpacker Are you sure you have a valid override?

Just tested the recipe and it downloads and updates munki flawless with the latest version TeamViewer-15.37.3.pkg

good luck :)

jannheider commented 1 year ago

Yes i deleted all overrides, that why I was wondering... hjuutilainen-recipes is up do date.

even run-in without an override, same result.

flammable commented 1 year ago

@jannheider It's working OK for me, too. Could you post the full output of what happens when you run your override (not running the recipe directly), with the -v flag?

jannheider commented 1 year ago

Ok, it works now... it turned out that I was connected to one of our older Jenkins build servers, it was running on Catalina.

In Catalina you don't have "aa", on our newer servers everything is working fine.

So I thing this issue can now be closed as it is fixed.

flammable commented 1 year ago

Nice, I'm glad you got it working! Tagging @hjuutilainen to close this issue, if he's OK with it.

hjuutilainen commented 1 year ago

Closing, thanks everyone!