search

autopkg / hjuutilainen-recipes

Recipes for AutoPkg
MIT License
49 stars 74 forks source link

Obsidian munki recipe fails #239

Closed fseesink closed 1 year ago

fseesink commented 1 year ago

Recently added the Obsidian.munki.recipe in my AutoPkgr setup, but haven't been able to get it to work.

First problem is that this recipe relies upon another in a different repo altogether, notably com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner. Though I had the hjuutilainen-recipes installed (hence being able to leverage the Obsidian.munki.recipe), clearly this external dependency doesn't get resolved when you install a repo. Took me a few to realize what I had to do, but eventually found this page: https://github.com/autopkg/grahampugh-recipes

where I found I had to simply add this repo with autopkg repo-add grahampugh/recipes-yaml.

However, with that done, now I get this:

 % autopkg run -vvv Obsidian.munki.recipe
Processing Obsidian.munki.recipe...
WARNING: processor path not found for processor: com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner
Failed.
Receipt written to /tmp/receipts/Obsidian.munki-receipt-20220907-172508.plist

The following recipes failed:
    Obsidian.munki.recipe
        Unknown processor 'com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner'.

Nothing downloaded, packaged or imported.

Isn't it considered bad form to have a recipe in one repo depend upon a recipe in another repo? But I see that it was @homebysix who's been updating the recipes in this external repo. So before I resort to building my own recipe using Recipe Robot, thought I would post here just in case.

hjuutilainen commented 1 year ago

It's quite common to see recipes to use processors from other repos but I think this should be documented as a requirement (which I haven't done for Obsidian recipe). Now that I look at the latest Obsidian release it seems that the application bundle has been fixed so that the icons file no longer has incorrect permissions.

I will update the Obsidian recipe and remove the com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner processor.

hjuutilainen commented 1 year ago

Fixed now in the latest commit.