search

autopkg / homebysix-recipes

AutoPkg recipes all the way from Seattle, WA.
Apache License 2.0
148 stars 114 forks source link

GoToMeetingURLProvider.py ERROR: 'LooseVersion' object has no attribute 'version' #402

Closed jgstew closed 3 years ago

jgstew commented 3 years ago

On Ubuntu docker container, this line in the GoToMeetingURLProvider.py throws an error:

https://github.com/autopkg/homebysix-recipes/blob/b9c1484128d1f5308bb66dcc4ca9e1be3536b0fc/GoToMeeting/GoToMeetingURLProvider.py#L34

According to this: https://github.com/bulletmark/libinput-gestures/issues/137

It should be resolved on Ubuntu by running the following:

sudo apt-get install libinput-tools

That said, this check should only be performed if platform is_mac so it shouldn't be throwing this error on Ubuntu in the first place. On top of that, if this error occurs on any platform, it should probably just be a pass since this check is so specific to older versions of MacOS.

try:
    # workaround for 10.12.x SNI issue
    if LooseVersion(platform.mac_ver()[0]) < LooseVersion("10.13.0"):
        HOSTNAME = socket.gethostbyname_ex("builds.cdn.getgo.com")[0]
except Exception:
    # log_err() maybe?
    pass

This GoToMeeting child recipe works on MacOS but not Ubuntu: https://github.com/jgstew/jgstew-recipes/blob/main/GoToMeeting/GoToMeeting-Win.download.recipe.yaml

Obviously running AutoPkg on Ubuntu is an edge case, but wherever possible I'm writing recipes and processors that work on MacOS/Ubuntu/Windows.

jgstew commented 3 years ago

Interesting. sudo apt-get install libinput-tools did NOT resolve the issue for me as mentioned in the other GitHub issue.

jgstew commented 3 years ago

This issue is resolved by PR: https://github.com/autopkg/homebysix-recipes/pull/446