search

autopkg / joshua-d-miller-recipes

My recipes for autopkg https://github.com/autopkg
13 stars 45 forks source link

Update Evernote.download.recipe #155

Closed TonyPaco closed 1 year ago

TonyPaco commented 1 year ago

Change re_pattern to get the zip url from the yaml being searched and use it to download the dmg.

joshua-d-miller commented 1 year ago

Just curious before I merge this that even though we are grabbing the zip URL and then using said URL to download the DMG it downloads a valid DMG?

TonyPaco commented 1 year ago

Yes. It gets the dmg.

It's really kind of a hack because the previous pattern would grab the entire yaml which was multiple links and would choke curl.

I looked for some kind of anchor in the middle of the yaml to better grab just one URL string. What I found was that "npath:" and I went with that because it looked consistent through all yaml entries on the page.

eshirk commented 1 year ago

Unless there's a reason to maintain a separate recipe, there's already an Evernote.download (and Evernote.munki) recipe at https://github.com/autopkg/recipes/tree/master/Evernote that are both being kept up-to date.