autopkg / joshua-d-miller-recipes

My recipes for autopkg https://github.com/autopkg
13 stars 46 forks source link

Mendeley Reference Manager download recipe failing #156

Closed eddiekelley closed 8 months ago

eddiekelley commented 1 year ago

We're seeing an error with the Mendeley Reference Manager for Desktop download recipe, and it seems to be an issue with the regex that's being used to search for the version.

Maybe this is an issue with the triple-digit-decimal in v.2.100.0 not matching the regex specified on line 37 of that recipe (is it searching for a decimal of length 2 in the minor version?):

<string>(?P&lt;Version&gt;\d\.\d{2}\.\d\.dmg)</string>

Steffan-Ravn commented 1 year ago

It's indeed where the problem arrises. I've created a pull request to fix it, but you can easily fix it yourself, either by changing it to 3 digits or, as I proposed in my PR, changing it to accept 1-3 digits: <string>(?P&lt;Version&gt;\d\.\d{1,3}\.\d\.dmg)</string>

paul-cossey commented 1 year ago

We've been running a temporary copy of your fix for this issue, @Steffan-Ravn, but it's failed again today.

I've got it working with a couple of changes

Not sure if you want to amend your PR, or I can knock up a new one?

Do you have a preference, @joshua-d-miller?

joshua-d-miller commented 8 months ago

Closing as this was merged.