autopkg / keeleysam-recipes

Recipes for autopkg!
Apache License 2.0
21 stars 49 forks source link

FileZilla download failing #142

Open eshirk opened 2 years ago

eshirk commented 2 years ago

I think the download URL may have changed, but the regex is eluding me. The current download URL is:

https://dl2.cdn.filezilla-project.org/client/FileZilla_3.58.0_macosx-x86.tar.bz2?h=B3vS3yBN3FjpFmGhmPZm_A&x=1644876098

donaldanixon commented 2 years ago

Someone just bought this up in MacAdmins slack, the code to fix it required adding the -x86 at the end of the file name, and removing the .app from the extension

`RE_PATTERN

<a href=\"(?P<url>http[s]?.*?(?P<filename>FileZilla_(?P<version>[\d.]+)_macosx-x86.*?\.tar\.bz2).*?)\" `
Cetartiodactyla commented 2 years ago

I’m getting this error. Anyone else?

Error in local.munki.FileZilla: Processor: URLTextSearcher: Error: No match found on URL: https://filezilla-project.org/download.php?show_all=1

fmiskic commented 2 years ago

I’m getting this error. Anyone else?

Error in local.munki.FileZilla: Processor: URLTextSearcher: Error: No match found on URL: https://filezilla-project.org/download.php?show_all=1

The fix is posted by @ResidentChief

Any update when the regex will get patched publicly?

Thanks!

homebysix commented 2 years ago

The fix is implemented in these two pull requests: https://github.com/autopkg/keeleysam-recipes/pull/143, https://github.com/autopkg/keeleysam-recipes/pull/144

@keeleysam - Could you merge one of those?

Darkomen78 commented 11 months ago

Hi everyone !

New download URL, macosx became macos :

<key>RE_PATTERN</key> <string>&lt;a href=\"(?P&lt;url&gt;http[s]?.*?(?P&lt;filename&gt;FileZilla_(?P&lt;version&gt;[\d.]+)_macos-x86.*?\.tar\.bz2).*?)\"</string>

Can we think of an option in the recipe to give choice of the arch ? x86 vs arm64