autopkg / keeleysam-recipes

Recipes for autopkg!
Apache License 2.0
21 stars 49 forks source link

Autopkg 2.7 Google Talk Plugin - Munki Pkg info Receipts Editor Python 3.10 error #148

Open lifeunexpected opened 2 years ago

lifeunexpected commented 2 years ago

The following failures occurred: Recipe: local.munki.Override.MicrosoftOffice365Suite

Message: Unable to import 'com.github.keeleysam.recipes.GoogleTalkPlugin/MunkiPkginfoReceiptsEditor', likely due to syntax or Python error.

This happened after upgrading to the new version of autopkg

AutoPkg now uses Python 3.10.6, and PyObjc 8.5. Python 3.10 brings several new general improvements and may result in some warnings or errors in processors still using some legacy Python2-conversion-to-3-isms. Please file appropriate issues with recipe authors or bring it to our attention in #autopkg in Slack. https://github.com/autopkg/autopkg/releases/tag/v2.7

TomBoehm commented 2 years ago

same for TeamViewerHostCustom

flammable commented 2 years ago

A bunch of recipes we use rely on this processor. I hope @vmiller's fix can be merged soon (thanks!).

precursorca commented 2 years ago

I also hope this can be merged soon. Affects: com.github.foigus.munki.microsoftremotedesktop com.github.dataJAR-recipes.munki.Microsoft Word 2019

mdt1024 commented 2 years ago

I'm experiencing this with the apizz-recipe for GoogleDrive.munki, wherein it can't find [read,write]Plist in plistlib module for autopkg version calling Python 3.10 out of ~/Library/Autopkg/Python3/Python.frameworks/Version/3.10/bin. My sol'n was to change [read,write]Plist into the methods used in 3.10 ('load' and 'dump') in MunkiPkginfoReceiptsEditor.py. I then ran autopkg update-trust-info for GoogleDrive.munki and now it's working.

nmcspadden commented 2 years ago

This processor was merged into core - MunkiOptionalReceiptsEditor. You don't need to use this specific shared processor anymore.

vmiller commented 2 years ago

Nice. Makes a lot of sense for this to be a core processor. Sounds like we need to file issues/pull requests to some recipes to use the new core processor.