search

autopkg / keeleysam-recipes

Recipes for autopkg!
Apache License 2.0
21 stars 49 forks source link

Receipteditor fix #149

Open vmiller opened 2 years ago

vmiller commented 2 years ago

This should fix issue #148

n8felton commented 1 year ago

Bump

flammable commented 1 year ago

@n8felton Check out the discussion here:

https://github.com/autopkg/keeleysam-recipes/issues/148#issuecomment-1242569230

All of the effort has been put towards migrating to the new core processor, so this PR probably isn't necessary anymore.

n8felton commented 1 year ago

Looks like I'm running into this issue, which is now pending this commit to get merged out of dev.

I wonder if accepting this PR is a good middle ground until upstream is worked out.

flammable commented 1 year ago

IMHO, merging this PR would mask the problem, since all of the recipes would immediately start working. If there's a way to deprecate processors (sort of like DeprecationWarning), that'd be ideal.

vmiller commented 1 year ago

What I did to work around https://github.com/autopkg/autopkg/issues/827 with the core processor as it is in the current release is to add a StopProcessingIf step to stop the recipe if nothing is imported. Example here https://github.com/autopkg/vmiller-recipes/blob/master/Sassafras/SassafrasClient.munki.recipe