Closed MLBZ521 closed 3 months ago
This should resolve #125.
@JDUBZzz @davidacland Just bumping and tagging for visibility. Thanks
@JDUBZzz @davidacland Just bumping and tagging again for visibility. Could this be reviewed and merged?
Thanks
Thanks @JDUBZzz!
The download issue is simply caused by this request header being included:
That said, none of the recently added request headers seem to be required. I've left them, just in case, but commented them out as it wasn't stated why they were added.
The issue described in 0f7bd7f is caused by the web server not accepting, or allowing, the etag
If-None-Match
and last modifiedIf-Modified-Since
checks. If these are not included, then the web server will not return a 400. Not quite sure why they're not supporting this as it literally should be saving them bandwidth... Anyways, even if you setCHECK_FILESIZE_ONLY
asTrue
in theURLDownloader
step, the parent classURLGetter
still adds the etag and last modified headers to thecurl
command. I'm not sure if this was an oversight or by design, but as far as I know, it hasn't affected anything else for all these years... I'll probably submit a PR to the autopkg repo and see what they think. If accepted, theFriendlyPathDeleter
step could then be removed. And then theCHECK_FILESIZE_ONLY
option will actually work as intended.Speaking of the
FriendlyPathDeleter
step, I also dialed back the heavy handed "sledgehammer" option and instead of deleting the entire directory, simply deleting the .dmg file itself as this is all that's actually required. So, this will at least allow history and created .pkgs to remain and those at least won't have to be re-created when they already exist.Finally I greatly simplified the .pkg recipe.