autopkg / n8felton-recipes

Recipes for Autopkg
28 stars 35 forks source link

Spark AR Studio #172

Closed paul-cossey closed 2 years ago

paul-cossey commented 2 years ago

Hi, @n8felton

As promised on issue https://github.com/autopkg/n8felton-recipes/issues/171. This PR amends the Spark AR Studio recipes to reflect the updated App name of Meta Spark Studio

However you may wish to depreciate these and have new recipes with Identifiers that match the Apps name? I'm happy to contribute those to your repo or alternatively we could host them?

Let me know your thoughts

Thanks Paul

Output of Munki Recipe autopkg run -v

autopkg run -v /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark\ AR\ Studio.munki.recipe
Processing /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark AR Studio.munki.recipe...
WARNING: /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark AR Studio.munki.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLDownloader
URLDownloader: Storing new Last-Modified header: Tue, 11 Oct 2022 18:14:58 GMT
URLDownloader: Downloaded /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/downloads/MetaSparkStudio.dmg
EndOfCheckPhase
CodeSignatureVerifier
CodeSignatureVerifier: Mounted disk image /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/downloads/MetaSparkStudio.dmg
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.p7qxPW/Meta Spark Studio.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.p7qxPW/Meta Spark Studio.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.p7qxPW/Meta Spark Studio.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
Versioner
Versioner: Mounted disk image /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/downloads/MetaSparkStudio.dmg
Versioner: Found version 148.0 in file /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/downloads/MetaSparkStudio.dmg/Meta Spark Studio.app/Contents/Info.plist
MunkiImporter
MunkiImporter: Using repo lib: AutoPkgLib
MunkiImporter:         plugin: FileRepo
MunkiImporter:           repo: /Users/Shared/munki_repo
MunkiImporter: Copied pkginfo to: /Users/Shared/munki_repo/pkgsinfo/apps/MetaSparkStudio/MetaSparkStudio-148.0.plist
MunkiImporter:            pkg to: /Users/Shared/munki_repo/pkgs/apps/MetaSparkStudio/MetaSparkStudio-148.0.dmg
Receipt written to /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/receipts/Spark AR Studio.munki-receipt-20221014-103647.plist

The following new items were downloaded:
    Download Path                                                                                            
    -------------                                                                                            
    /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.munki.SparkARStudio/downloads/MetaSparkStudio.dmg  

The following new items were imported into Munki:
    Name             Version  Catalogs  Pkginfo Path                                      Pkg Repo Path                                   Icon Repo Path  
    ----             -------  --------  ------------                                      -------------                                   --------------  
    MetaSparkStudio  148.0    testing   apps/MetaSparkStudio/MetaSparkStudio-148.0.plist  apps/MetaSparkStudio/MetaSparkStudio-148.0.dmg   

Output of Pkg Recipe autopkg run -v

autopkg run -v /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark\ AR\ Studio.pkg.recipe
Processing /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark AR Studio.pkg.recipe...
WARNING: /Users/paul/Documents/GitHub/n8felton-recipes/Facebook/Spark AR Studio.pkg.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLDownloader
URLDownloader: Storing new Last-Modified header: Tue, 11 Oct 2022 18:14:58 GMT
URLDownloader: Downloaded /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg
EndOfCheckPhase
CodeSignatureVerifier
CodeSignatureVerifier: Mounted disk image /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.JYDdAG/Meta Spark Studio.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.JYDdAG/Meta Spark Studio.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.JYDdAG/Meta Spark Studio.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
Versioner
Versioner: Mounted disk image /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg
Versioner: Found version 148.0 in file /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg/Meta Spark Studio.app/Contents/Info.plist
AppPkgCreator
AppPkgCreator: Mounted disk image /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg
AppPkgCreator: Using path '/private/tmp/dmg.62AzfN/Meta Spark Studio.app' matched from globbed '/private/tmp/dmg.62AzfN/*.app'.
AppPkgCreator: BundleID: com.facebook.arstudio.skylight
AppPkgCreator: Copied /private/tmp/dmg.62AzfN/Meta Spark Studio.app to /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/payload/Applications/Meta Spark Studio.app
AppPkgCreator: Connecting
AppPkgCreator: Sending packaging request
AppPkgCreator: Disconnecting
Receipt written to /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/receipts/Spark AR Studio.pkg-receipt-20221014-104222.plist

The following new items were downloaded:
    Download Path                                                                                          
    -------------                                                                                          
    /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/downloads/MetaSparkStudio.dmg  

The following packages were built:
    Identifier                      Version  Pkg Path                                                                                             
    ----------                      -------  --------                                                                                             
    com.facebook.arstudio.skylight  148.0    /Users/paul/Library/AutoPkg/Cache/com.github.n8felton.pkg.SparkARStudio/Meta Spark Studio-148.0.pkg 
n8felton commented 2 years ago

I think I'd prefer to deprecate the old name and use the updated name for "new" recipes.

These recipes were used at my $oldJob, so I no longer have a personal investment in them. I'm happy to continue to host them in my repo, or we can deprecate the old name in my repo, and let you move the "new" recipes with the new name in your repo.

paul-cossey commented 2 years ago

Thanks, @n8felton

Ok, depreciation and new recipes work for me. If you're still happy to host, from a continuity perspective it's probably better if you keep them?

I'll close this and knock up a new PR for the changes.