search

autopkg / nstrauss-recipes

Public AutoPkg recipes
23 stars 27 forks source link

Remove NAME variable from app paths #1

Closed homebysix closed 5 years ago

homebysix commented 5 years ago

Because variables can be overridden, it's a good idea to make sure that the recipe will still work even if a non-default variables used. One issue that would prevent recipes from running is using a NAME variable in paths that should be hard-coded (e.g. /Applications/Foo.app).

This PR removes the NAME variable from all file paths and replaces it with the actual app name, which should make the recipe more resilient for overrides.

nstrauss commented 5 years ago

Thanks for the tip. Also a good chance to review these recipes. Turns out Dremel DigiLab 3D Slicer was broken due to zipped directory structure changing.

Will merge right now and then fix separately.