search

autopkg / nstrauss-recipes

Public AutoPkg recipes
23 stars 27 forks source link

Google Earth Pro URL change #11

Closed mrowell closed 4 years ago

mrowell commented 4 years ago

The Google Earth Pro URL for the latest release has changed (note added rel="noopener") <a href="https://dl.google.com/dl/earth/client/advanced/current/googleearthpromac-intel-7.3.3.dmg" rel="noopener">v7.3.3 for Mac</a>

Previously: <a href="https://dl.google.com/dl/earth/client/advanced/current/googleearthpromac-intel-7.3.2.dmg">v7.3.2 for Mac</a>

The current regex pattern is skipping the latest version because of the rel="noopener" attribute.

The Pattern could be changed from:

       <key>RE_PATTERN</key>
        <string>&lt;a href=&quot;(?P&lt;url&gt;https:\/\/.*\/googleearthpromac.*\.dmg)&quot;&gt;</string>

To:

      <key>RE_PATTERN</key>
        <string>&lt;a href=&quot;(?P&lt;url&gt;https:\/\/.*\/googleearthpromac.*\.dmg)&quot;</string>
nstrauss commented 4 years ago

Thanks for the report. Regex has been updated to reflect your suggested change.

New version also comes with a new developer ID used to sign the package. Updated both and recipes should be working as expected with 76b1dcd34a8548e9a55e52685a36030f3150ce9e