search

autopkg / nstrauss-recipes

Public AutoPkg recipes
23 stars 27 forks source link

GoProQuik - Expired Certificate. #45

Closed paul-cossey closed 1 year ago

paul-cossey commented 1 year ago

Hi, @nstrauss

The GoProQuick download recipe is currently failing with this error.

Processor: CodeSignatureVerifier: Error: Code signature verification failed. Note that all verification can be disabled by setting the variable DISABLE_CODE_SIGNATURE_VERIFICATION to a non-empty value.

The certificate on the package expired yesterday. Screenshot 2023-03-02 at 11 38 37

Maybe this is because it's no longer supported/discontinued by the vendor? All I can see reference to here https://gopro.com/en/us/shop/quik-app-video-photo-editor is iPhone or iPad app.

paul-cossey commented 1 year ago

Bit more digging, I can see it's now classed as legacy software: https://community.gopro.com/s/article/GoPro-legacy-software?language=en_US

nstrauss commented 1 year ago

@paul-cossey Would you prefer I remove code signature verification or the recipe altogether? Assuming you already have the package imported into your repo, there will be no future versions. Open to either. I have no plans to use this product again.

paul-cossey commented 1 year ago

I'm not sure the installer would even run with an expired cert?

But tbh I think if it were one of our recipes I'd deprecate it. We'll be removing it from our repo so won't have a need for it going forward.

nstrauss commented 1 year ago

Deprecation warning added! https://github.com/autopkg/nstrauss-recipes/commit/95a9d9b4045fef400e2ba606004e0132fd6a421f