search

autopkg / nstrauss-recipes

Public AutoPkg recipes
23 stars 27 forks source link

Use URLGetter for SimpleJSONParser processor #7

Closed homebysix closed 4 years ago

homebysix commented 4 years ago

This PR adjusts the SimpleJSONParser processor to use the new URLGetter superclass, which will ease the transition to Python 3 and AutoPkg 2.

Here's a log of the adjusted processor in action, using the TestNav download recipe that references it: https://gist.github.com/homebysix/294583c52e72ad3708ad06f1c948d626

nstrauss commented 4 years ago

Thanks for all your work, Elliot. Confirmed recipe URLGetter changes work.

Only thing to watch out for with future URLGetter PRs it to make sure affected recipes have their MinimumVersion string bumped to 1.4. URLGetter isn't available in earlier versions and the recipe may fail.

homebysix commented 4 years ago

Good point! I've got pre-commit hooks set up for catching MinimumVersion, and will probably submit that later once the initial PRs settle down.