search

autopkg / orchard-recipes

Repo for autopkg recipes created by the University of Oxford Orchard Mac team.
GNU General Public License v3.0
2 stars 14 forks source link

Fix StatPlus #6

Closed chelming closed 6 years ago

chelming commented 6 years ago

StatPlus changed from .zip/.dmg/.app to a .zip/.app and the recipe was failing since there's no more DMG.

Because it's just a .app in a .zip I added a pkg recipe to package it up before sending it to munki. I think this is also preferable for anyone who might want to create a JSS recipe or a .install recipe in the future.

I moved the code signature verification to the download recipe since that seems to be the generally accepted way of doing things and because it needs to be there when moving to having a pkg recipe.

The .app has proper version strings in the Info.plist so I got rid of the versioning stuff.

I also changed the spaces to tabs since half the file was tabbed and it's also the standard for plists.

Sample run:

$ autopkg run StatPlus_mac_LE/StatPlus_mac_LE.munki.recipe -v
Processing StatPlus_mac_LE/StatPlus_mac_LE.munki.recipe...
WARNING: StatPlus_mac_LE/StatPlus_mac_LE.munki.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLDownloader
URLDownloader: Item at URL is unchanged.
URLDownloader: Using existing /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/downloads/statplusmacle.zip
EndOfCheckPhase
Unarchiver
Unarchiver: Guessed archive format 'zip' from filename statplusmacle.zip
Unarchiver: Unarchived /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/downloads/statplusmacle.zip to /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE
CodeSignatureVerifier
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE/StatPlus.app: valid on disk
CodeSignatureVerifier: /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE/StatPlus.app: satisfies its Designated Requirement
CodeSignatureVerifier: /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE/StatPlus.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
AppPkgCreator
AppPkgCreator: Using path '/Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE/StatPlus.app' matched from globbed '/Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE/*.app'.
AppPkgCreator: Version: 6.2.6.1
AppPkgCreator: BundleID: com.analystsoft.mst.pro2
AppPkgCreator: Package already exists at path /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE.pkg.
AppPkgCreator: Existing package matches version and identifier, not building.
FileFinder
FileFinder: Found file match: '/Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/StatPlus_mac_LE.pkg' from globbed '/Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/*.pkg'
MunkiImporter
MunkiImporter: Copied pkginfo to /munki/pkgsinfo/StatPlus_mac_LE/StatPlus_mac_LE-6.2.6.1.plist
MunkiImporter: Copied pkg to /munki/pkgs/StatPlus_mac_LE/StatPlus_mac_LE-6.2.6.1.pkg
Receipt written to /Users/cwhits/Library/AutoPkg/Cache/uk.ac.ox.orchard.munki.StatPlus_mac_LE/receipts/StatPlus_mac_LE.munki-receipt-20171020-114924.plist

The following new items were imported into Munki:
    Name             Version  Catalogs  Pkginfo Path                                   Pkg Repo Path                                
    ----             -------  --------  ------------                                   -------------                                
    StatPlus_mac_LE  6.2.6.1  testing   StatPlus_mac_LE/StatPlus_mac_LE-6.2.6.1.plist  StatPlus_mac_LE/StatPlus_mac_LE-6.2.6.1.pkg
chelming commented 6 years ago

Any chance of getting this merged?

fuzzylogiq commented 6 years ago

thanks for this!