search

autopkg / precursorca-recipes

Recipes for AutoPkg
1 stars 7 forks source link

add essential xml header #14

Closed grahampugh closed 1 year ago

grahampugh commented 1 year ago

There is a missing xml header in RemoteUpdateManager.M1.pkg.recipe which causes your whole repo to be rejected. For those of us using AutoPkg betas with the recipe-map model, this breaks all autopkg runs until your repo is removed from the repo list.

This PR fixes it.

I notice that the recipe is in a folder named "beta". This might be a good indication to put recipes that are not ready to go live in a repo outside of the autopkg org, or in a dev branch.

homebysix commented 1 year ago

This is also causing issues with my automation for testing new AutoPkg search methods. I'd suggest merging this ASAP.

precursorca commented 1 year ago

I have reverted the recipe to what it was before I screwed it up so badly yesterday.

Will review the recipe offline / off GitHub and will not post until I have something trouble free.

My apologies for messing this up and causing issues with other recipes.

Alex Narvey @.***

On Dec 9, 2022, at 3:25 PM, Elliot Jordan @.***> wrote:

This is also causing issues with my automation for testing new AutoPkg search methods. I'd suggest merging this ASAP.

— Reply to this email directly, view it on GitHub https://github.com/autopkg/precursorca-recipes/pull/14#issuecomment-1344797266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG7VES4CQBTLYBTDF6FHZTWMOPWDANCNFSM6AAAAAASZU6FYM. You are receiving this because you are subscribed to this thread.

mpanighetti commented 1 year ago

It looks like this was partially copied from a PR I submitted to another repo. It should work fine with the XML header line restored as in this PR.

mpanighetti commented 1 year ago

Since the recipe was reverted outside of this PR, this can be closed without merging. @precursorca