autopkg / recipes

Recipes for AutoPkg
231 stars 206 forks source link

Update to use CFBundleVersion with Skype #414

Closed joeschmolo closed 2 years ago

joeschmolo commented 2 years ago

Update to use CFBundleVersion with Skype for correct version as CFBundleShortVersionString does not include point updates.

homebysix commented 2 years ago

Works for me.

% autopkg run -vv Skype/Skype.pkg.recipe      
Processing Skype/Skype.pkg.recipe...
WARNING: Skype/Skype.pkg.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLDownloader
{'Input': {'filename': 'Skype.dmg', 'url': 'https://go.skype.com/mac.download'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: Storing new Last-Modified header: Tue, 07 Dec 2021 10:07:35 GMT
URLDownloader: Storing new ETag header: 0x8D9B969648D6058
URLDownloader: Downloaded ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg
{'Output': {'download_changed': True,
            'etag': '0x8D9B969648D6058',
            'last_modified': 'Tue, 07 Dec 2021 10:07:35 GMT',
            'pathname': '~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg',
            'url_downloader_summary_result': {'data': {'download_path': '~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg'},
                                              'summary_text': 'The following '
                                                              'new items were '
                                                              'downloaded:'}}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
CodeSignatureVerifier
{'Input': {'input_path': '~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg/Skype.app',
           'requirement': 'anchor apple generic and identifier '
                          '"com.skype.skype" and (certificate '
                          'leaf[field.1.2.840.113635.100.6.1.9] /* exists */ '
                          'or certificate 1[field.1.2.840.113635.100.6.2.6] /* '
                          'exists */) and certificate '
                          'leaf[field.1.2.840.113635.100.6.1.13] /* exists */ '
                          'and certificate leaf[subject.OU] = AL798K98FX'}}
CodeSignatureVerifier: Mounted disk image ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.GN1ctS/Skype.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.GN1ctS/Skype.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.GN1ctS/Skype.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
{'Output': {}}
PlistReader
{'Input': {'info_path': '~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg/Skype.app',
           'plist_keys': {'CFBundleVersion': 'version'}}}
PlistReader: Mounted disk image ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg
PlistReader: Reading: /private/tmp/dmg.pjIllj/Skype.app/Contents/Info.plist
PlistReader: Assigning value of '8.79.0.95' to output variable 'version'
{'Output': {'plist_reader_output_variables': {'version': '8.79.0.95'}}}
AppPkgCreator
{'Input': {'version': '8.79.0.95'}}
AppPkgCreator: Mounted disk image ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg
AppPkgCreator: Using path '/private/tmp/dmg.T6qCma/Skype.app' matched from globbed '/private/tmp/dmg.T6qCma/*.app'.
AppPkgCreator: BundleID: com.skype.skype
AppPkgCreator: Copied /private/tmp/dmg.T6qCma/Skype.app to ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/payload/Applications/Skype.app
AppPkgCreator: Connecting
AppPkgCreator: Sending packaging request
AppPkgCreator: Disconnecting
AppPkgCreator: Failed to close socket: [Errno 9] Bad file descriptor
{'Output': {'app_pkg_creator_summary_result': {'data': {'identifier': 'com.skype.skype',
                                                        'pkg_path': '~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/Skype-8.79.0.95.pkg',
                                                        'version': '8.79.0.95'},
                                               'report_fields': ['identifier',
                                                                 'version',
                                                                 'pkg_path'],
                                               'summary_text': 'The following '
                                                               'packages were '
                                                               'built:'},
            'new_package_request': True,
            'version': '8.79.0.95'}}
Receipt written to ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/receipts/Skype.pkg-receipt-20211211-102418.plist

The following new items were downloaded:
    Download Path                                                                          
    -------------                                                                          
    ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/downloads/Skype.dmg  

The following packages were built:
    Identifier       Version    Pkg Path                                                                               
    ----------       -------    --------                                                                               
    com.skype.skype  8.79.0.95  ~/Library/AutoPkg/Cache/com.github.autopkg.pkg.Skype/Skype-8.79.0.95.pkg