autopkg / recipes

Recipes for AutoPkg
231 stars 206 forks source link

Acrobat Adobe Reader DC has been reverted to Acrobat Adobe Reader (DC removed) #439

Closed n8felton closed 1 year ago

n8felton commented 2 years ago

It appears that with version 2022.003.20258 of Adobe Acrobat Reader, Adobe has reverted the App bundle name from "Acrobat Adobe Reader DC" to the previous "Acrobat Adobe Reader", dropping the "DC".

This breaks a few things in the existing AdobeReaderDC.munki recipe.

https://github.com/autopkg/recipes/blob/01a422ed45f994dd21208137c3ca8d3d00588f03/AdobeReader/AdobeReaderDC.munki.recipe#L19-L24

https://github.com/autopkg/recipes/blob/01a422ed45f994dd21208137c3ca8d3d00588f03/AdobeReader/AdobeReaderDC.munki.recipe#L37-L43

https://github.com/autopkg/recipes/blob/01a422ed45f994dd21208137c3ca8d3d00588f03/AdobeReader/AdobeReaderDC.munki.recipe#L89-L101

My recommendation is to deprecate the AdobeReaderDC. recipes, then modernize (if needed) and restore the AdobeReader. recipes.

Daz-wallace commented 2 years ago

This also breaks the .pkg recipe that checks the Info.plist in the Application bundle for the version:

stephanvanhienen commented 2 years ago

When running the 'revived' Acrobat Reader recipe it downloads a really old version. Looks like the OS detection is not working ok. Also there is a warning that this recipe will be removed soon ?

autopkg run AdobeReader.munki -v Processing AdobeReader.munki... WARNING: AdobeReader.munki is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding... DeprecationWarning DeprecationWarning: This recipe will soon be removed. Please remove it from your list of recipes. AdobeReaderURLProvider AdobeReaderURLProvider: WARNING: Please update the OS_VERSION in your override from '10.8.0' to 'Mac OS 10.8.0' AdobeReaderURLProvider: [displayName] : Reader 11.0.10 English for Mac AdobeReaderURLProvider: [version] : 11.0.10 AdobeReaderURLProvider: [download_url]: https://ardownload2.adobe.com/pub/adobe/reader/mac/11.x/11.0.10/ReSign/en_US/AdbeRdr11010_en_US.dmg URLDownloader URLDownloader: Storing new Last-Modified header: Fri, 24 Feb 2017 09:33:27 GMT URLDownloader: Storing new ETag header: "6731d9a-549436c09835b" URLDownloader: Downloaded /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/downloads/AdobeReader.dmg EndOfCheckPhase CodeSignatureVerifier CodeSignatureVerifier: Mounted disk image /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/downloads/AdobeReader.dmg CodeSignatureVerifier: Using path '/private/tmp/dmg.yEt19F/Adobe Reader XI Installer.pkg' matched from globbed '/private/tmp/dmg.yEt19F/*.pkg'. CodeSignatureVerifier: Verifying installer package signature... CodeSignatureVerifier: Package "Adobe Reader XI Installer.pkg": CodeSignatureVerifier: Status: signed by a developer certificate issued by Apple for distribution CodeSignatureVerifier: Signed with a trusted timestamp on: 2017-02-23 10:31:43 +0000 CodeSignatureVerifier: Certificate Chain: CodeSignatureVerifier: 1. Developer ID Installer: Adobe Systems, Inc. (JQ525L2MZD) CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: 45 02 B6 EB AA C8 56 12 A8 82 5D 34 C0 7C 86 FB 8C 16 AF 0F 47 55 CodeSignatureVerifier: 05 C6 98 A8 02 1A F6 7D 5C 95 CodeSignatureVerifier: ------------------------------------------------------------------------ CodeSignatureVerifier: 2. Developer ID Certification Authority CodeSignatureVerifier: Expires: 2027-02-01 22:12:15 +0000 CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: 7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03 CodeSignatureVerifier: F2 9C 88 CF B0 B1 BA 63 58 7F CodeSignatureVerifier: ------------------------------------------------------------------------ CodeSignatureVerifier: 3. Apple Root CA CodeSignatureVerifier: Expires: 2035-02-09 21:40:36 +0000 CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C CodeSignatureVerifier: 68 C5 BE 91 B5 A1 10 01 F0 24 CodeSignatureVerifier: CodeSignatureVerifier: Signature is valid CodeSignatureVerifier: Authority name chain is valid DeprecationWarning DeprecationWarning: This recipe will soon be removed. Please remove it from your list of recipes. FlatPkgUnpacker FlatPkgUnpacker: Mounted disk image /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/downloads/AdobeReader.dmg FlatPkgUnpacker: Unpacked /private/tmp/dmg.PUoEO9/Adobe Reader XI Installer.pkg to /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/pkg_unpack PkgRootCreator PkgRootCreator: Created /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/application_payload/Applications PkgPayloadUnpacker PkgPayloadUnpacker: Unpacked /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/pkg_unpack/application.pkg/Payload to /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/application_payload/Applications MunkiInstallsItemsCreator MunkiInstallsItemsCreator: Created installs item for /Applications/Adobe Reader.app MunkiPkginfoMerger MunkiPkginfoMerger: Merged {'installs': [{'CFBundleIdentifier': 'com.adobe.Reader', 'CFBundleName': 'Adobe Reader', 'CFBundleShortVersionString': '11.0.10', 'CFBundleVersion': '11.0.10', 'minosversion': '10.4.3', 'path': '/Applications/Adobe Reader.app', 'type': 'application', 'version_comparison_key': 'CFBundleShortVersionString'}]} into pkginfo MunkiImporter MunkiImporter: Using repo lib: AutoPkgLib MunkiImporter: plugin: FileRepo MunkiImporter: repo: /System/Volumes/Data/Mounts/weblinux2-munki.thevalley.nl/munki MunkiImporter: Copied pkginfo to: /System/Volumes/Data/Mounts/weblinux2-munki.thevalley.nl/munki/pkgsinfo/apps/Adobe/AdobeReader-11.0.10.plist MunkiImporter: pkg to: /System/Volumes/Data/Mounts/weblinux2-munki.thevalley.nl/munki/pkgs/apps/Adobe/AdobeReader-11.0.10.dmg Receipt written to /Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/receipts/AdobeReader-receipt-20221025-143833.plist

The following recipes have deprecation warnings: Name Warning


AdobeReader.munki  This recipe will soon be removed. Please remove it from your list of recipes.  
AdobeReader.munki  This recipe will soon be removed. Please remove it from your list of recipes.  

The following new items were downloaded: Download Path


/Users/admin/Library/AutoPkg/Cache/com.github.autopkg.munki.AdobeReader/downloads/AdobeReader.dmg  

The following new items were imported into Munki: Name Version Catalogs Pkginfo Path Pkg Repo Path Icon Repo Path


AdobeReader  11.0.10  testing   apps/Adobe/AdobeReader-11.0.10.plist  apps/Adobe/AdobeReader-11.0.10.dmg                  
stephanvanhienen commented 2 years ago

We are running macOS 12.6.1 and I don't have an override file.

nmcspadden commented 2 years ago

You must always create an override file to run recipes, and override the OS_VERSION in it.

If you have questions about this, please email the autopkg-discuss mailing list, or seek out #autopkg on Slack. Please keep Github issues on topic.

On Tue, Oct 25, 2022 at 5:44 AM stephanvanhienen @.***> wrote:

We are running macOS 12.6.1 and I don't have an override file.

— Reply to this email directly, view it on GitHub https://github.com/autopkg/recipes/issues/439#issuecomment-1290495501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFTX3WNKIX4R64ZGHMHTTWE7IZJANCNFSM6AAAAAARDJBZ3I . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Nick McSpadden @.***