search

autopkg / rtrouton-recipes

Recipes for AutoPkg
MIT License
131 stars 93 forks source link

EndNote 20 - MunkiImporter requires missing argument pkg_path #107

Closed Peter-Erik closed 3 years ago

Peter-Erik commented 3 years ago

Thanks for update to EndNote 20 but there is an error:

The following recipes failed: endnote20.munki MunkiImporter requires missing argument pkg_path

The following recipes failed: endnote20.pkg MunkiImporter requires missing argument pkg_path

If you look at previous recipes (older versions) the EndNote20.install.recipe is missing (or is this not required any more?)

rtrouton commented 3 years ago

Please talk to @oliverweinm, as he sent in the Endnote 20 recipes.

Peter-Erik commented 3 years ago

OK will do that thanks rtrouton

oliverweinm commented 3 years ago

Strange, thanks for the tip. I will look into it @Peter-Erik

Peter-Erik commented 3 years ago

@oliverweinm - Thanks for making this recipe take your time

ckostovny commented 3 years ago

I see the same behavior as @Peter-Erik, I'm not using Munki. Is this happening because EndNote20.pkg.recipe has ParentRecipe set to com.github.rtrouton.munki.EndNote20 instead of com.github.rtrouton.download.EndNote20? Thanks for any assistance.

rtrouton commented 3 years ago

I've updated the ParentRecipe in the EndNote20 pkg recipe and it looks like the pkg recipe now works OK. I have not tested the .munki recipe.

oliverweinm commented 3 years ago

Okay, it really seems to have been a wrong value for the parent recipe key in the munki recipe (and the pkg recipe which has now been fixed by @rtrouton, thanks for that!). It's been fixed in https://github.com/autopkg/rtrouton-recipes/pull/109 and the .munki recipe now runs for me(, as does the .pkg recipe). I'm still baffled as to how I didn't catch that. I apologize for any inconveniences.

Peter-Erik commented 3 years ago

Strange still error with .munki

.pkg and .download works now

The following recipes failed: endnote20.munki MunkiImporter requires missing argument pkg_path

oliverweinm commented 3 years ago

Hi @Peter-Erik , that's (hopefully) because my pull request #109 hasn't been merged/accepted yet.

rtrouton commented 3 years ago

Now merged.

Peter-Erik commented 3 years ago

Sorry was to fast - need to read first then check ;-)

oliverweinm commented 3 years ago

Hi @Peter-Erik, the recipe seems to be working for me now. Can you confirm the same?

Peter-Erik commented 3 years ago

Hi @oliverweinm works! - thanks for your effort.