search

autopkg / smithjw-recipes

Smithjw's AutoPkg recipes
Apache License 2.0
14 stars 16 forks source link

Added munki recipe in yaml #21

Closed jby closed 2 years ago

jby commented 2 years ago

Here's a PR with a munki recipe, in yaml format

smithjw commented 2 years ago

Just looking at this one @jby but as you've set the parent to be the .download recipe, the app delivered to Munki would only be the raw DMG downloaded from the website, and not the packaged version that contains the custom post-install script to set things up completely for the end-user.

It also doesn't cater for the naming %NAME%-%ARCHITECTURE%-%version%.

I've just added a few more changes to the recipe... Can you test and confirm it works as expected @jby / @patgmac

jby commented 2 years ago

Ok @smithjw - I haven't done any yaml-recipes before, this was my first try. I'll try out your changes.

jby commented 2 years ago

I'd say that it works as expected now. I've added the key

    supported_architectures: '%ARCHITECTURE%'

as well. Might as well do it in this recipe to alleviate the need to do it in local overrides.

jby commented 2 years ago

And, I think that if you switch ´name´ and ´display_name´ it should use the defined icon properly as well.

smithjw commented 2 years ago

20