autopkg / smithjw-recipes

Smithjw's AutoPkg recipes
Apache License 2.0
14 stars 16 forks source link

Key 'supported_architectures' should be an array and not only a string #23

Closed jby closed 1 year ago

jby commented 2 years ago

To work properly with munkiadmin according to @hjuutilainen:

https://macadmins.slack.com/archives/C0D7FU2Q1/p1647623269525709 https://macadmins.slack.com/archives/C0D7FU2Q1/p1647632972333489

Plus a cleanup of the name variable according to @gregneagle Munki will handle the different architectures

jby commented 2 years ago

Hmm, the naming change is needed for the pkg-recipe as well... To avoid having Docker-arch.pkg files, which doesn't match the pkgsinfo-files in munki...

eithor commented 1 year ago

Please note that if you change the pkg recipe to just NAME for the pkg-name it will fail for those that use e.g. Jamf and not Munki and require unique pkg names

jby commented 1 year ago

Please note that if you change the pkg recipe to just NAME for the pkg-name it will fail for those that use e.g. Jamf and not Munki and require unique pkg names

Sure, but this PR was directed specifically towards a Munki recipe...

eithor commented 1 year ago

Please note that if you change the pkg recipe to just NAME for the pkg-name it will fail for those that use e.g. Jamf and not Munki and require unique pkg names

Sure, but this PR was directed specifically towards a Munki recipe...

@jby I understand, though I was thinking about your comment above (second from the top) where you say that the pkg-recipe also needs to be changed.

smithjw commented 1 year ago

@jby @eithor I'm probably going to close this PR as I've created a new set of Universal recipes that pkg both Intel and Arm versions into the one pkg. Yes, it's significantly larger because it's packaging both installers, but also a lot simpler for admins.