search

autopkg / thenikola-recipes

3 stars 11 forks source link

Remove NAME variable from app paths #26

Closed homebysix closed 5 years ago

homebysix commented 5 years ago

Because variables can be overridden, it's a good idea to make sure that the recipe will still work even if a non-default variables used. One issue that would prevent recipes from running is using a NAME variable in paths that should be hard-coded (e.g. /Applications/Foo.app).

This PR removes the NAME variable from all file paths and replaces it with the actual app name, which should make the recipe more resilient for overrides.

thenikola commented 5 years ago

Hi Elliot, sorry it took me so long to get to this I kind of forgot about it. I don't currently have the time to test these patches because I'm involved in a large project and do not currently do Mac administration. They do seem like a good idea to me. Can you verify that they did not break any of the recipes and I can merge the request? If you don't have time I'll get to it probably next month.

homebysix commented 5 years ago

Hi @thenikola - I just tested the 5 modified recipes, and they all ran successfully except for TinyGrab.download. However the TinyGrab failure was not related to the modifications I made. Looks like the developer's website is offline. (I'll submit a separate PR to deprecate the TinyGrab recipes.)

The following recipes failed:
    TinyGrab/TinyGrab.download.recipe
        Error in com.github.autopkg.download.TinyGrab: Processor: SparkleUpdateInfoProvider: Error: Could not retrieve URL http://tinygrab.com/appcast/tinygrab-appcast.xml:

Thanks!

thenikola commented 5 years ago

Thanks again for the pull request @homebysix